Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming Timeseries #838

Closed
wants to merge 13 commits into from

Conversation

matteobachetti
Copy link
Member

@matteobachetti matteobachetti commented Sep 4, 2024

These new methods serve the purpose of streaming time series objects by segment. This is a prerequisite for the parallelization of the Averaged*spectrum calculation.

@pep8speaks
Copy link

pep8speaks commented Sep 4, 2024

Hello @matteobachetti! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1472:69: E203 whitespace before ':'
Line 1476:41: E203 whitespace before ':'
Line 2802:101: E501 line too long (111 > 100 characters)

Comment last updated at 2024-09-09 08:58:27 UTC

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 95.20000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.20%. Comparing base (241f81a) to head (0e0c1c8).

Files with missing lines Patch % Lines
stingray/base.py 91.52% 5 Missing ⚠️
stingray/gti.py 98.41% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (241f81a) and HEAD (0e0c1c8). Click for more details.

HEAD has 74 uploads less than BASE
Flag BASE (241f81a) HEAD (0e0c1c8)
78 4
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #838       +/-   ##
===========================================
- Coverage   96.53%   79.20%   -17.33%     
===========================================
  Files          48       48               
  Lines        9257     9336       +79     
===========================================
- Hits         8936     7395     -1541     
- Misses        321     1941     +1620     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matteobachetti matteobachetti marked this pull request as draft November 11, 2024 09:08
@matteobachetti
Copy link
Member Author

I converted to draft. There is some work to be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants